Attention is currently required from: fixeria, pespin, dexter.
falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32740 )
Change subject: gsm630: make osmo_hr_check_sid compatible with RFC 5993
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
No, IMO this function should be kept unchanged and it should remain the caller's responsibility to m […]
@fixeria - I concur. I am going to post my thoughts on the whole issue under the OS#5688 ticket in Redmine - please give me a little more time, I am still researching.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/32740
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25728299b757fbc87dd1b3f5adaec9b8b240c5d1
Gerrit-Change-Number: 32740
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia
falcon@freecalypso.org
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Wed, 17 May 2023 18:19:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment