Change in osmo-iuh[master]: tests/tests_common.c: Add missing header
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26768 ) Change subject: tests/tests_common.c: Add missing header ...................................................................... tests/tests_common.c: Add missing header The header is probably indirectly added by osmocom/iuh/hnbgw.h, but once that's dropped, really weird stuff happens, like talloc crashing in talloc_total_blocks() because the compiled code incorrectly fills msgb_ctx variable in return of msgb_talloc_ctx_init. Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf --- M src/tests/test_common.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/68/26768/1 diff --git a/src/tests/test_common.c b/src/tests/test_common.c index 9663157..bfe487f 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -36,6 +36,7 @@ #include <osmocom/core/application.h> #include <osmocom/core/talloc.h> #include <osmocom/core/logging.h> +#include <osmocom/core/msgb.h> #include <osmocom/ranap/ranap_common.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf Gerrit-Change-Number: 26768 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-MessageType: newchange
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26768 ) Change subject: tests/tests_common.c: Add missing header ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf Gerrit-Change-Number: 26768 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 06:37:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26768 ) Change subject: tests/tests_common.c: Add missing header ...................................................................... Patch Set 1: Code-Review+1 FYI: it's adding an include of a header, not "adding a header". -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf Gerrit-Change-Number: 26768 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 09:43:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26768 ) Change subject: tests/tests_common.c: Add missing header ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf Gerrit-Change-Number: 26768 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 10:21:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26768 ) Change subject: tests/tests_common.c: Add missing header ...................................................................... tests/tests_common.c: Add missing header The header is probably indirectly added by osmocom/iuh/hnbgw.h, but once that's dropped, really weird stuff happens, like talloc crashing in talloc_total_blocks() because the compiled code incorrectly fills msgb_ctx variable in return of msgb_talloc_ctx_init. Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf --- M src/tests/test_common.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/tests/test_common.c b/src/tests/test_common.c index 9663157..bfe487f 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -36,6 +36,7 @@ #include <osmocom/core/application.h> #include <osmocom/core/talloc.h> #include <osmocom/core/logging.h> +#include <osmocom/core/msgb.h> #include <osmocom/ranap/ranap_common.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26768 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7dab8d18d316632989406a9f22917e00a7fd68bf Gerrit-Change-Number: 26768 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged
participants (3)
-
fixeria -
laforge -
pespin