Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 to look at the new patch set (#3). Change subject: hnbgw: drop dead code from MSC_UnitdataCallback ...................................................................... hnbgw: drop dead code from MSC_UnitdataCallback This RANAP RESET code... a) is not used: osmo-hnbgw has only recently started sending RANAP UnitData by its own initiative. Until very recently, osmo-hnbgw has only responded to receiving a RESET, with an ACK. It has never sent a RESET message to the peer, here titan. b) makes no sense: RANAP RESET handling is actually implemented in RAN_EMulation.ttcnpp. c) makes no sense: The UnitDataCallback happens when osmo-hnbgw sends a RANAP UnitData to titan: if at all, the only logical response would be a RESET ACK message, not a RESET message. Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e --- M hnbgw/HNBGW_Tests.ttcn 1 file changed, 25 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/73/33473/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33473 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7b9022e991b63b945c7ec6e5c9f7c4eb5da4d7e Gerrit-Change-Number: 33473 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: newpatchset