neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28225 ) Change subject: pfcp ie: tweak CP Function Features ...................................................................... pfcp ie: tweak CP Function Features The spec indicates three bytes of CP Function Features, but both wireshark and ttcn3 expect only one byte. This makes sense because only eight CP F.F. flags are defined. Drop those two always-zero bytes, hence pass the wireshark dissector and ttcn3 parsing without warnings. Related: SYS#5599 Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5 --- M include/osmocom/pfcp/pfcp_ies_custom.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/pfcp/pfcp_ies_custom.h b/include/osmocom/pfcp/pfcp_ies_custom.h index 9f26550..c28fdb2 100644 --- a/include/osmocom/pfcp/pfcp_ies_custom.h +++ b/include/osmocom/pfcp/pfcp_ies_custom.h @@ -73,7 +73,7 @@ * printf("%s\n", osmo_pfcp_bits_to_str_c(x.bits, osmo_pfcp_cp_feature_strs)); */ struct osmo_pfcp_ie_cp_function_features { - uint8_t bits[3]; + uint8_t bits[1]; }; /* 3GPP TS 29.244 8.2.37 */ -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28225 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Icda891a2f3401e58f142f229465403d5dc8befe5 Gerrit-Change-Number: 28225 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-MessageType: merged