Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/31108 )
Change subject: layer23: Support configuring GSMTAP through VTY in l23 apps.
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/47506186_d27c1bcf
PS2, Line 13: gsmtap
The 'gsmtap' prefix in each command looks redundant to me, given that they all
belong to 'gsmtap' node.
File src/host/layer23/include/osmocom/bb/common/l23_app.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/31108/comment/f147e573_6bd89028
PS2, Line 19: bts
BTS?
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/31108
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I2582a1633d37d350a7f4c2bb5e03793bdf46e839
Gerrit-Change-Number: 31108
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 30 Jan 2023 19:56:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment