Attention is currently required from: neels.

dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/43515?usp=email )

Change subject: personalization: EF_SMSP: keep same length as found in template ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

Patchset:

PS2: I have checked this back and as far as I can see everything is correct here. Just a few cosmetic issues...

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/43515/comment/229e1c45_b8049dc7?usp=ema... : PS2, Line 11: can modify the value in the template without having to patch this code. I think its more like 42 is a correct length. Its an arbitrary decision that the profile vendor makes as he sees fit.

Now you have commented the line out where you set the record length. This means that the template default now applies. Which is 38 as far as I can see. This matches what the eUICC Profile Package: Interoperable Format Technical Specification specifies.

So everything should be correct. However, I would recommend to rephrase the commit message a bit and just say that now the template default applies.

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/43515/comment/04b72d6b_6d5d0713?usp=ema... : PS2, Line 640: #f_smsp.rec_len = 42 If wou want to make i perfect, you can put a space between # and f_smsp....