[L] Change in osmo-bts[master]: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2 - gerrit-log

18 May 2023


      Attention is currently required from: falconia, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32714 )
Change subject: TCH DL, FR & EFR: reshape SIDs per 06.31/06.81 section 5.1.2
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
Patchset:
PS5: 
It looks now much more enclosed with the helper functions :)
File include/osmo-bts/lchan.h:
https://gerrit.osmocom.org/c/osmo-bts/+/32714/comment/dedab85d_fc853fc3 
PS5, Line 281: 		} dtx_fr_efr;
I know I proposed this name, but I didn't remember about HR at the time, so now looking at other naming you used in the .c file, it may make sense to name this one also dtx_fr_hr_efr?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32714
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I924ab21952dcf8bb03ba7ccef790474bf66fc9e5
Gerrit-Change-Number: 32714
Gerrit-PatchSet: 5
Gerrit-Owner: falconia falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: falconia falcon@freecalypso.org
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Thu, 18 May 2023 08:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment