Attention is currently required from: dexter, jolly.

laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43042?usp=email )

Change subject: V1.2: Add function ES10b.ReturnFromFallback ......................................................................

Patch Set 3:

(1 comment)

File src/ipa/main.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43042/comment/9308da02_3b5c02c8?... : PS3, Line 42: tatic void print_help(void) : { : printf("options:\n"); : printf(" -h ......................... print this text.\n"); : printf(" -t TAC ..................... set TAC (default: %s)\n", DEFAULT_TAC); : printf(" -e eimId ................... set preferred eIM (in case the eUICC has multiple)\n"); : printf(" -r N ....................... set reader number (default: %d)\n", DEFAULT_READER_NUMBER); : printf(" -c N ....................... set logical channel number (default: %d)\n", DEFAULT_CHANNEL_NUMBER); : printf(" -f PATH .................... set initial eIM configuration\n"); : printf(" -m ......................... reset eUICC memory\n"); : printf(" --refresh-flag.............. Make eUICC send a CAT refresh after switching profile\n"); : printf(" --execute-fallback-mechanism Trigger enabling of fallback profile\n"); : printf(" --return-from-fallback...... Trigger return from fallback profile to previous profile\n"); : printf(" -n PATH .................... path to nvstate file (default: %s)\n", DEFAULT_NVSTATE_PATH); : printf(" -y NUM ..................... number of retries for ESipa requests (default: %u)\n", : DEFAULT_ESIPA_REQ_RETRIES); : printf(" -a ......................... ask end user for consent\n"); : printf(" -C ......................... CA (Certificate Authority) Bundle file\n"); : printf(" -S ......................... disable HTTPS\n"); : printf(" -I ......................... disable SSL certificate verification (insecure)\n"); : printf(" -E ......................... emulate IoT eUICC (compatibility mode to use consumer eUICCs)\n"); : printf(" -1 ......................... force the IPAd to process only one eUICC package (debug, use with caution)\n"); : } I have a general problem with this flat approach of options, mixing actual flags/options (like -t/-e/-r/-c/-n/-y/-a/-C/-S/-I/-E/-1) with the actual operations.

The operation like execute-fallback-mechanism or return-from-fallback are exclusive-or and modify what the tool does in general. Those should be something like `--mode initial-eim-config|execute-fallback-mechanism|return-from-fallback|normal` or `--operation ...` with a defualt to normal operation. OR osme other syntax that distinguishes the operational mode from optional flags.