Attention is currently required from: laforge, pespin.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email )

Change subject: Add DSCP configuration support for server transport role ......................................................................

Patch Set 4:

(3 comments)

File src/ss7_xua_srv_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/a218a8f9_4bca70... : PS3, Line 152: "ip-dscp " IP_DSCP_RANGE_STR,

Please also change the names of the functions and commands inside DEFUN_ATTR to adapt to the new nam […]

Done

File src/ss7_xua_srv_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/4970a1cc_bd1095... : PS4, Line 167: NO_STR "Reset IP DSCP of Listener to default\n",

The NO_STR usually means we write the next param the same way as in the positive case iirc.

Done

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/63c214c0_6ed27b... : PS4, Line 256: vty_out(vty, " ip-dscp %u%s", xs->cfg.ip_dscp, VTY_NEWLINE);

the fact that this (with non-matching name) passes build verification also shows that the vty test i […]

Done