Attention is currently required from: fixeria.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37848?usp=email )
Change subject: pySim.esim.saip: maintain a parsed fileystem hierarchy
......................................................................
Patch Set 5:
(1 comment)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37848/comment/33b8c84e_90ae4c0f?usp=ema... :
PS1, Line 100: def __init__(self, pename: str, l: Optional[List[Tuple]] = None, template:
:
I meant making the constructor accept `**kw` rather than adding even more `Optional` parameters: […]
I prefer to keept it as-is, we're only talking about four arguments at this point.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/37848?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2caadc24b1087855f23f3c57cdf8dabbf81757c0
Gerrit-Change-Number: 37848
Gerrit-PatchSet: 5
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Sun, 18 Aug 2024 17:41:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de