Attention is currently required from: pespin. matanp has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33750 ) Change subject: ctrl: Support adding si2quater earfcn neighbor ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/33750/comment/e7a454ed_f7f28242 PS3, Line 888: if ((0 == result) && (si2q_num(bts) <= SI2Q_MAX_NUM)) {

we usuall compare "var == value" not the other way around. […] Ack

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33750 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd2740ee54db66742785437a278cb9244e1f76d0 Gerrit-Change-Number: 33750 Gerrit-PatchSet: 4 Gerrit-Owner: matanp <matan1008@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Fri, 14 Jul 2023 12:20:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment