Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email )
Change subject: common: stop buffering UL measurements when SACCH is deactivated
......................................................................
Patch Set 2:
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42911/comment/09f713e0_8858d7f8?usp=... :
PS2, Line 2989: return -RSL_ERR_EQUIPMENT_FAIL;
you are lreaving the bool above enabled in this error code path. Is that fine?It probably makes sense to move it to the end of the func?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7
Gerrit-Change-Number: 42911
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 29 Jun 2026 20:26:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No