Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 ) Change subject: GTP mockup: allow single GTP devices in mockup mode ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-upf/+/28986/comment/36f92eaa_7e0f315e PS1, Line 20: TTCN3 tests do query osmo-upf to list currently active tunnels, so the

why do you need mockup mode in TTCN3 in first place? […] The real-world reason is that so far there is no GTP testing in the TTCN3 tests yet. So I ran in GTP mokup mode, and noticed that it is unfortunate that in mockup mode, the VTY does not show any GTP actions. Active GTP actions are put in a list located in the struct upf_gtp_dev, so to list mocked-up actions, i need a GTP device struct present. That's how i came to implement a GTP device that does not do anything but still lists the actions it would have done. Now I am finding justifications for that useful code, after the fact.

In a lab or production environment, it could become a good thing to turn individual APNs into mockup mode. The mockup mode should list the fake GTP actions. idk, do you guys think the mockup stuff is a non-feature? maybe i'm spinning off on a tangent here. In general the mockup stuff is very useful for running tests without root access, or on a linux kernel that does not have (recent enough) GTP kernel support. But I don't really have that situation, I'm just lazy to constantly put cap_net_admin on the binary... That's no good justification on its own, but I figured it could still help someone some day. If we keep the mockup, this patch makes it better by listing the fake actions. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 09 Aug 2022 23:19:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment