Attention is currently required from: Hoernchen, lynxis lazus.

dexter has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43136?usp=email )

Change subject: GP: mixed PSK TLS PUT KEY (Amendment B Table 3-13) ......................................................................

Patch Set 1: Code-Review+1

(2 comments)

Patchset:

PS1: I would recommend to add an integration test as well. In /tests/pySim-shell_test/gp/test_put_delete_key.script we put an AES128 into the ISD-R of a sysmoEUICC1.

We could extend the test so that it also tests the other variants (AES256 and DES) and in particular the AES PSK + DES DEK variant.

File pySim/global_platform/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/43136/comment/c86af4a1_735aeb55?usp=ema... : PS1, Line 655: (b'\x85' + bertlv_encode_len(len(block)) + block + : bytes([len(kcv)]) + kcv)

I would have preferred the use of our object-oriented BER_TLV_IE encoder for the 0x85 as well as som […]

Yes, this should definitely handled by a construct definition.