Change in libosmo-sccp[master]: rate_ctr: Use legal counter group prefixes / names (no '.' allowed)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 16 10:23:40 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26258 )

Change subject: rate_ctr: Use legal counter group prefixes / names (no '.' allowed)
......................................................................

rate_ctr: Use legal counter group prefixes / names (no '.' allowed)

This avoids log messages like
DLGLOBAL <0016> rate_ctr.c:92 'sigtran.as' is not a valid counter group identifier

Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf
---
M src/osmo_ss7.c
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 76fbdbd..1cb6c82 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -897,12 +897,12 @@
  ***********************************************************************/
 
 static const struct rate_ctr_desc ss7_as_rcd[] = {
-	[SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" },
-	[SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" },
+	[SS7_AS_CTR_RX_MSU_TOTAL] = { "rx:msu:total", "Total number of MSU received" },
+	[SS7_AS_CTR_TX_MSU_TOTAL] = { "tx:msu:total", "Total number of MSU transmitted" },
 };
 
 static const struct rate_ctr_group_desc ss7_as_rcgd = {
-	.group_name_prefix = "sigtran.as",
+	.group_name_prefix = "sigtran_as",
 	.group_description = "SIGTRAN Application Server",
 	.num_ctr = ARRAY_SIZE(ss7_as_rcd),
 	.ctr_desc = ss7_as_rcd,
@@ -1152,13 +1152,13 @@
 };
 
 static const struct rate_ctr_desc ss7_asp_rcd[] = {
-	[SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "Total number of packets received" },
-	[SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx.packets.unknown", "Number of packets received for unknown PPID" },
-	[SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx.packets.total", "Total number of packets transmitted" },
+	[SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx:packets:total", "Total number of packets received" },
+	[SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx:packets:unknown", "Number of packets received for unknown PPID" },
+	[SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx:packets:total", "Total number of packets transmitted" },
 };
 
 static const struct rate_ctr_group_desc ss7_asp_rcgd = {
-	.group_name_prefix = "sigtran.asp",
+	.group_name_prefix = "sigtran_asp",
 	.group_description = "SIGTRAN Application Server Process",
 	.num_ctr = ARRAY_SIZE(ss7_asp_rcd),
 	.ctr_desc = ss7_asp_rcd,

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26258
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf
Gerrit-Change-Number: 26258
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211116/61feadac/attachment.htm>


More information about the gerrit-log mailing list