Change in libosmo-sccp[master]: osmo_ss7: properly unlink rate_counter on AS/ASP free

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 16 10:20:23 UTC 2021


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/26259 )


Change subject: osmo_ss7: properly unlink rate_counter on AS/ASP free
......................................................................

osmo_ss7: properly unlink rate_counter on AS/ASP free

When introducing rate_couters, I forgot to call
rate_ctr_group_free().  I thought free'ing the parent object
via talloc is sufficient, but that obviously misses the point that
rate_counters have an internal linked list from which they must be
unlinked.

Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/59/26259/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 1cb6c82..b4c0b51 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1111,6 +1111,7 @@
 
 	as->inst = NULL;
 	llist_del(&as->list);
+	rate_ctr_group_free(as->ctrg);
 	talloc_free(as);
 }
 
@@ -1574,6 +1575,7 @@
 	/* unlink from ss7_instance */
 	asp->inst = NULL;
 	llist_del(&asp->list);
+	rate_ctr_group_free(asp->ctrg);
 	/* release memory */
 	talloc_free(asp);
 }

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/26259
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974
Gerrit-Change-Number: 26259
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211116/a388102c/attachment.htm>


More information about the gerrit-log mailing list