<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26259">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmo_ss7: properly unlink rate_counter on AS/ASP free<br><br>When introducing rate_couters, I forgot to call<br>rate_ctr_group_free().  I thought free'ing the parent object<br>via talloc is sufficient, but that obviously misses the point that<br>rate_counters have an internal linked list from which they must be<br>unlinked.<br><br>Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974<br>---<br>M src/osmo_ss7.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/59/26259/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 1cb6c82..b4c0b51 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -1111,6 +1111,7 @@</span><br><span> </span><br><span>    as->inst = NULL;</span><br><span>  llist_del(&as->list);</span><br><span style="color: hsl(120, 100%, 40%);">+  rate_ctr_group_free(as->ctrg);</span><br><span>    talloc_free(as);</span><br><span> }</span><br><span> </span><br><span>@@ -1574,6 +1575,7 @@</span><br><span>    /* unlink from ss7_instance */</span><br><span>       asp->inst = NULL;</span><br><span>         llist_del(&asp->list);</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_group_free(asp->ctrg);</span><br><span>   /* release memory */</span><br><span>         talloc_free(asp);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26259">change 26259</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26259"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8d27f025c22776d0153d867e36c073ef716eb974 </div>
<div style="display:none"> Gerrit-Change-Number: 26259 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>