<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26258">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rate_ctr: Use legal counter group prefixes / names (no '.' allowed)<br><br>This avoids log messages like<br>DLGLOBAL <0016> rate_ctr.c:92 'sigtran.as' is not a valid counter group identifier<br><br>Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf<br>---<br>M src/osmo_ss7.c<br>1 file changed, 7 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c</span><br><span>index 76fbdbd..1cb6c82 100644</span><br><span>--- a/src/osmo_ss7.c</span><br><span>+++ b/src/osmo_ss7.c</span><br><span>@@ -897,12 +897,12 @@</span><br><span>  ***********************************************************************/</span><br><span> </span><br><span> static const struct rate_ctr_desc ss7_as_rcd[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-     [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx.msu.total", "Total number of MSU received" },</span><br><span style="color: hsl(0, 100%, 40%);">-     [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx.msu.total", "Total number of MSU transmitted" },</span><br><span style="color: hsl(120, 100%, 40%);">+        [SS7_AS_CTR_RX_MSU_TOTAL] = { "rx:msu:total", "Total number of MSU received" },</span><br><span style="color: hsl(120, 100%, 40%);">+   [SS7_AS_CTR_TX_MSU_TOTAL] = { "tx:msu:total", "Total number of MSU transmitted" },</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_group_desc ss7_as_rcgd = {</span><br><span style="color: hsl(0, 100%, 40%);">-     .group_name_prefix = "sigtran.as",</span><br><span style="color: hsl(120, 100%, 40%);">+  .group_name_prefix = "sigtran_as",</span><br><span>         .group_description = "SIGTRAN Application Server",</span><br><span>         .num_ctr = ARRAY_SIZE(ss7_as_rcd),</span><br><span>   .ctr_desc = ss7_as_rcd,</span><br><span>@@ -1152,13 +1152,13 @@</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_desc ss7_asp_rcd[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-      [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx.packets.total", "Total number of packets received" },</span><br><span style="color: hsl(0, 100%, 40%);">-    [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx.packets.unknown", "Number of packets received for unknown PPID" },</span><br><span style="color: hsl(0, 100%, 40%);">-     [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx.packets.total", "Total number of packets transmitted" },</span><br><span style="color: hsl(120, 100%, 40%);">+       [SS7_ASP_CTR_PKT_RX_TOTAL] = { "rx:packets:total", "Total number of packets received" },</span><br><span style="color: hsl(120, 100%, 40%);">+  [SS7_ASP_CTR_PKT_RX_UNKNOWN] = { "rx:packets:unknown", "Number of packets received for unknown PPID" },</span><br><span style="color: hsl(120, 100%, 40%);">+   [SS7_ASP_CTR_PKT_TX_TOTAL] = { "tx:packets:total", "Total number of packets transmitted" },</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_group_desc ss7_asp_rcgd = {</span><br><span style="color: hsl(0, 100%, 40%);">-   .group_name_prefix = "sigtran.asp",</span><br><span style="color: hsl(120, 100%, 40%);">+ .group_name_prefix = "sigtran_asp",</span><br><span>        .group_description = "SIGTRAN Application Server Process",</span><br><span>         .num_ctr = ARRAY_SIZE(ss7_asp_rcd),</span><br><span>  .ctr_desc = ss7_asp_rcd,</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26258">change 26258</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/26258"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I08666a1c3c1345cd3b0e55d544f6ac4a6df62fbf </div>
<div style="display:none"> Gerrit-Change-Number: 26258 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>