Change in osmo-pcu[master]: Add new PDCH UL Controller, drop SBAllocator class

pespin gerrit-no-reply at
Fri Mar 12 14:29:00 UTC 2021

Hello Jenkins Builder, laforge, fixeria, lynxis lazus, 

I'd like you to reexamine a change. Please visit

to look at the new patch set (#8).

Change subject: Add new PDCH UL Controller, drop SBAllocator class

Add new PDCH UL Controller, drop SBAllocator class

Right now we handle different types of UL allocations in different
classes like PollAllocator and SBAllocator, and they usually don't take
into account the other one in most cases. Furthermore, those objects are
usually per-BTS object, instead of per PDCH object.

This is a first step towards having a unified per-PDCH controller which
takes care of controlling what is scheduled and hence expected on the
uplink. Each PDCH has a UL Controller which keeps track of all reserved
uplink frame, be it SB, RRBP poll or USF assigned, all under the same

As a first step, only the SBA part is fully implemented and used (being
it the easiest part to replace); TBF poll+usf will come in follow-up
patches later on. As a result, the SBAllocator per-BTS class dissappears
but some of its code is refactored/reused to provide more features to the
gprs_rlcmac_sba object, which is also further integrated into the new UL

Related: OS#5020
Change-Id: I84b24beea4a1aa2c1528f41435f77bd16df2b947
M src/
M src/bts.cpp
M src/bts.h
M src/gprs_rlcmac_sched.cpp
M src/pcu_l1_if.cpp
M src/pcu_utils.h
M src/pdch.cpp
M src/pdch.h
A src/pdch_ul_controller.c
A src/pdch_ul_controller.h
M src/poll_controller.cpp
A src/sba.c
D src/sba.cpp
M src/sba.h
M src/tbf.cpp
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
17 files changed, 443 insertions(+), 225 deletions(-)

  git pull ssh:// refs/changes/91/23291/8
To view, visit
To unsubscribe, or for help writing mail filters, visit

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I84b24beea4a1aa2c1528f41435f77bd16df2b947
Gerrit-Change-Number: 23291
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin at>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at>
Gerrit-Reviewer: laforge <laforge at>
Gerrit-Reviewer: lynxis lazus <lynxis at>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the gerrit-log mailing list