This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23291 ) Change subject: Add new PDCH UL Controller, drop SBAllocator class ...................................................................... Patch Set 7: (5 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c File src/pdch_ul_controller.c: https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@39 PS7, Line 39: /* > #if 0 I can actually remove this. https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@55 PS7, Line 55: iterate over rb-tree and free whatever > Doesn't talloc do this for us once you free() the ulc? Yes, I can drop this. https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@79 PS7, Line 79: this > I would avoid using a keyword as a symbol name. I know it's not C++ code, but still. Ack https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@102 PS7, Line 102: /* It's OK if we don't find one, this func is used by RTS to see if we need to schedule one */ > Without FIXME / TODO, this looks like an early development leftover? […] I'll remove the commented log. https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@129 PS7, Line 129: this > Again keywords... It's confusing to see them used as symbol names in a mixed C / C++ project. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23291 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I84b24beea4a1aa2c1528f41435f77bd16df2b947 Gerrit-Change-Number: 23291 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-Comment-Date: Fri, 12 Mar 2021 13:49:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/01aeda81/attachment.htm>