Change in osmo-pcu[master]: Add new PDCH UL Controller, drop SBAllocator class

fixeria gerrit-no-reply at lists.osmocom.org
Fri Mar 12 13:28:12 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23291 )

Change subject: Add new PDCH UL Controller, drop SBAllocator class
......................................................................


Patch Set 7: Code-Review+1

(5 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c 
File src/pdch_ul_controller.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@39 
PS7, Line 39: /*
#if 0


https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@55 
PS7, Line 55: iterate over rb-tree and free whatever
Doesn't talloc do this for us once you free() the ulc?


https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@79 
PS7, Line 79: this
I would avoid using a keyword as a symbol name. I know it's not C++ code, but still.


https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@102 
PS7, Line 102: 		/* It's OK if we don't find one, this func is used by RTS to see if we need to schedule one */
Without FIXME / TODO, this looks like an early development leftover?
If the logging message is still useful, then let's uncomment and use LOGL_DEBUG.


https://gerrit.osmocom.org/c/osmo-pcu/+/23291/7/src/pdch_ul_controller.c@129 
PS7, Line 129: this
Again keywords... It's confusing to see them used as symbol names in a mixed C / C++ project.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I84b24beea4a1aa2c1528f41435f77bd16df2b947
Gerrit-Change-Number: 23291
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Fri, 12 Mar 2021 13:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210312/9a15bab6/attachment.htm>


More information about the gerrit-log mailing list