Change in osmo-pcu[master]: Add new PDCH UL Controller, drop SBAllocator class

osmith gerrit-no-reply at lists.osmocom.org
Mon Mar 15 16:17:53 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/23291 )

Change subject: Add new PDCH UL Controller, drop SBAllocator class
......................................................................


Patch Set 8: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/23291/8/src/pdch_ul_controller.c 
File src/pdch_ul_controller.c:

https://gerrit.osmocom.org/c/osmo-pcu/+/23291/8/src/pdch_ul_controller.c@29 
PS8, Line 29: ?
Why the question mark, is this an unresolved TODO?


https://gerrit.osmocom.org/c/osmo-pcu/+/23291/8/src/pdch_ul_controller.c@96 
PS8, Line 96: new
(with "new" as variable name, gerrit syntax highlighting is confused. maybe use another one?)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/23291
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I84b24beea4a1aa2c1528f41435f77bd16df2b947
Gerrit-Change-Number: 23291
Gerrit-PatchSet: 8
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Mar 2021 16:17:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210315/04137448/attachment.htm>


More information about the gerrit-log mailing list