Change in osmo-bsc[master]: Add vty command for Ericsson RBS2000 sync

keith gerrit-no-reply at lists.osmocom.org
Thu Mar 11 19:59:17 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23317 )

Change subject: Add vty command for Ericsson RBS2000 sync
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c 
File src/osmo-bsc/abis_om2000_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@495 
PS2, Line 495: 	if (!strcmp(argv[0], "external"))
> "else if", or simply else.
ah right.. saves an instruction i guess. 
I actually wondered about these vty functions;  if we should return CMD_SUCCESS only for a recognized param. 

if somehow the function were to be called with a invalid param should return an error (which is impossible from the vty, right?)

so instead of if else, it would be ifs with early returm?


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@681 
PS2, Line 681: 	if (bts->rbs2000.sync_src >= 0) {
> I don't see sync_src being < 0 anywhere. […]
you're (both) right of course - this is a hangover from an earlier draft when this code was in bsc_vty.c and before we initialised the member.

@javi can you remove the condition? (remember, if you git rebase -i first it's easier to amend the commit)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d1acd6b3442238b35fc911092e12a6ac989adb
Gerrit-Change-Number: 23317
Gerrit-PatchSet: 2
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Mar 2021 19:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/5c93b9fd/attachment.htm>


More information about the gerrit-log mailing list