Change in osmo-bsc[master]: Add vty command for Ericsson RBS2000 sync

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 11 20:03:26 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23317 )

Change subject: Add vty command for Ericsson RBS2000 sync
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c 
File src/osmo-bsc/abis_om2000_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@495 
PS2, Line 495: 	if (!strcmp(argv[0], "external"))
> ah right.. saves an instruction i guess.  […]
VTY internal code is parsing the parameters and making sure whatever is passed to this function is either "internal" or "external", so there's no need for checking any other possibilities.
I would even strongly discourage doing that kind of extra checks because if it ever happens, it's a bug which for sure should be fixed in core VTY code, and doing these kind of assumptions could even hide those kind of issues.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d1acd6b3442238b35fc911092e12a6ac989adb
Gerrit-Change-Number: 23317
Gerrit-PatchSet: 2
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Mar 2021 20:03:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/2c40f353/attachment.htm>


More information about the gerrit-log mailing list