Change in osmo-bsc[master]: Add vty command for Ericsson RBS2000 sync

pespin gerrit-no-reply at lists.osmocom.org
Thu Mar 11 14:21:02 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23317 )

Change subject: Add vty command for Ericsson RBS2000 sync
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2//COMMIT_MSG@9 
PS2, Line 9: This commit adds support for Selection of syncronization source
Missing dot at end of line?


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h@381 
PS2, Line 381: 			int sync_src;
enum om2k_sync_src sync_src;


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c 
File src/osmo-bsc/abis_om2000_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@495 
PS2, Line 495: 	if (!strcmp(argv[0], "external"))
"else if", or simply else.


https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@681 
PS2, Line 681: 	if (bts->rbs2000.sync_src >= 0) {
I don't see sync_src being < 0 anywhere.
As I wrote in other comment, using enum type for this variable would also make it clear.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23317
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia3d1acd6b3442238b35fc911092e12a6ac989adb
Gerrit-Change-Number: 23317
Gerrit-PatchSet: 2
Gerrit-Owner: javi-tic <javi at tic-ac.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Mar 2021 14:21:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/c4e6d0a5/attachment.htm>


More information about the gerrit-log mailing list