This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23317 ) Change subject: Add vty command for Ericsson RBS2000 sync ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/include/osmocom/bsc/bts.h@381 PS2, Line 381: int please use 'enum om2k_sync_src' as type here. https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c File src/osmo-bsc/abis_om2000_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@495 PS2, Line 495: if else if https://gerrit.osmocom.org/c/osmo-bsc/+/23317/2/src/osmo-bsc/abis_om2000_vty.c@681 PS2, Line 681: sync_src >= 0 AFAIU, this condition is always true for both variants? I would just print it unconditionally. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia3d1acd6b3442238b35fc911092e12a6ac989adb Gerrit-Change-Number: 23317 Gerrit-PatchSet: 2 Gerrit-Owner: javi-tic <javi at tic-ac.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: keith <keith at rhizomatica.org> Gerrit-Comment-Date: Thu, 11 Mar 2021 14:17:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210311/2a0c35c9/attachment.htm>