Change in pysim[master]: pySim-shell: add "dir" command.

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 3 08:16:57 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23207 )

Change subject: pySim-shell: add "dir" command.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/23207/1/pySim/utils.py 
File pySim/utils.py:

https://gerrit.osmocom.org/c/pysim/+/23207/1/pySim/utils.py@784 
PS1, Line 784: 	cellwith = len(longest_str) + hspace
In general I'm surprised we have to implement this ourselves rather than using some kind of existing module. Did you check out https://cmd2.readthedocs.io/en/latest/features/table_creation.html ?

In any case, if implemented ourselves, this could benefit in terms of future compatibility from the use of cmd2.ansi.style_aware_wcswidth()

https://cmd2.readthedocs.io/en/latest/features/generating_output.html#columnar-output



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic06a60e0a0ec54d9bb26e151453ceb49d69e3df7
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/19714e75/attachment.htm>


More information about the gerrit-log mailing list