Change in pysim[master]: pySim-shell: add "dir" command.

laforge gerrit-no-reply at lists.osmocom.org
Wed Mar 3 08:06:10 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/23207 )

Change subject: pySim-shell: add "dir" command.
......................................................................


Patch Set 1:

Curious that you chouse "dir" over "ls".

As you just extended the get_selectables() with a comprehensive set of flags, it makes sense to also expose this to the user.  I would argue that "ls" or "dir" should always show all options by default (making it identical to tab completion) but there's either a separate command, or ls/dir itself, that allows fine-grained controls like "ls --fids" or "ls --apps".


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/23207
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic06a60e0a0ec54d9bb26e151453ceb49d69e3df7
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:06:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/b97e3716/attachment.htm>


More information about the gerrit-log mailing list