<p><a href="https://gerrit.osmocom.org/c/pysim/+/23207">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/pysim/+/23207/1/pySim/utils.py">File pySim/utils.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/pysim/+/23207/1/pySim/utils.py@784">Patch Set #1, Line 784:</a> <code style="font-family:monospace,monospace">   cellwith = len(longest_str) + hspace</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In general I'm surprised we have to implement this ourselves rather than using some kind of existing module. Did you check out https://cmd2.readthedocs.io/en/latest/features/table_creation.html ?</p><p style="white-space: pre-wrap; word-wrap: break-word;">In any case, if implemented ourselves, this could benefit in terms of future compatibility from the use of cmd2.ansi.style_aware_wcswidth()</p><p style="white-space: pre-wrap; word-wrap: break-word;">https://cmd2.readthedocs.io/en/latest/features/generating_output.html#columnar-output</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/23207">change 23207</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/23207"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic06a60e0a0ec54d9bb26e151453ceb49d69e3df7 </div>
<div style="display:none"> Gerrit-Change-Number: 23207 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 03 Mar 2021 08:16:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>