Change in pysim[master]: transport/pcsc: work around Python 3.5 bug: do not call disconnect()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Mar 1 17:42:03 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17283 )

Change subject: transport/pcsc: work around Python 3.5 bug: do not call disconnect()
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17283/3/pySim/transport/pcsc.py 
File pySim/transport/pcsc.py:

https://gerrit.osmocom.org/c/pysim/+/17283/3/pySim/transport/pcsc.py@43 
PS3, Line 43: 		# self._con.disconnect()
> What about simply except: here? And probably "pass" on the except if python version is <=3.5. […]
This sounds like a good option.

I am wondering, do we really need this destructor?
I guess self._con has its own destructor, and it would do the cleanup anyway...



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17283
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee
Gerrit-Change-Number: 17283
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Mar 2021 17:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/fbe5055e/attachment.htm>


More information about the gerrit-log mailing list