Change in pysim[master]: transport/pcsc: work around Python 3.5 bug: do not call disconnect()

pespin gerrit-no-reply at lists.osmocom.org
Mon Mar 1 17:37:17 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17283 )

Change subject: transport/pcsc: work around Python 3.5 bug: do not call disconnect()
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17283/3/pySim/transport/pcsc.py 
File pySim/transport/pcsc.py:

https://gerrit.osmocom.org/c/pysim/+/17283/3/pySim/transport/pcsc.py@43 
PS3, Line 43: 		# self._con.disconnect()
What about simply except: here? And probably "pass" on the except if python version is <=3.5.3



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17283
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee
Gerrit-Change-Number: 17283
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 01 Mar 2021 17:37:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210301/36f96a60/attachment.htm>


More information about the gerrit-log mailing list