Change in pysim[master]: transport/pcsc: work around Python 3.5 bug: do not call disconnect()

fixeria gerrit-no-reply at lists.osmocom.org
Wed Mar 3 17:49:01 UTC 2021


Hello Jenkins Builder, fixeria, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/pysim/+/17283

to look at the new patch set (#4).

Change subject: transport/pcsc: work around Python 3.5 bug: do not call disconnect()
......................................................................

transport/pcsc: work around Python 3.5 bug: do not call disconnect()

Unfortunately, Debian ships old Python (3.5 vs 3.8) and old pyscard
(1.9.4 vs 1.9.9). Calling PCSCCardConnection.disconnect() from a
destructor causes warnings about ignored exceptions:

  AttributeError: 'NoneType' object has no attribute 'disconnect'
  AttributeError: 'NoneType' object has no attribute 'setChanged'
  AttributeError: 'NoneType' object has no attribute 'SCardDisconnect'
  TypeError: 'NoneType' object is not callable

All these exceptions happen in pyscard's own destructors.

Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee
---
M pySim/transport/pcsc.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/83/17283/4
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17283
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9c644bc5fe9791b141a30bfc13647d77937a82ee
Gerrit-Change-Number: 17283
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210303/98c6acd2/attachment.htm>


More information about the gerrit-log mailing list