Change in libosmocore[master]: ctrl: Pre-calculate required size before allocating msgb

laforge gerrit-no-reply at lists.osmocom.org
Thu Jun 10 15:37:46 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24639 )

Change subject: ctrl: Pre-calculate required size before allocating msgb
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24639/1/src/ctrl/control_cmd.c 
File src/ctrl/control_cmd.c:

https://gerrit.osmocom.org/c/libosmocore/+/24639/1/src/ctrl/control_cmd.c@a526 
PS1, Line 526: 	msg = msgb_alloc_headroom(4096, 128, "ctrl command make");
allocating same-sized msgbs is a big tradition in osmocom, the idea is that there's less memory fragmentation this way.  But given all our msgbs are typically very short-lived, we can probably ignore it.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24639
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0b8f370f7b08736207f9efed13a0663b5e482824
Gerrit-Change-Number: 24639
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 15:37:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/b16112a4/attachment.htm>


More information about the gerrit-log mailing list