Change in libosmocore[master]: ctrl: Pre-calculate required size before allocating msgb

pespin gerrit-no-reply at lists.osmocom.org
Thu Jun 10 15:30:06 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24639 )

Change subject: ctrl: Pre-calculate required size before allocating msgb
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/24639/1/tests/ctrl/ctrl_test.c 
File tests/ctrl/ctrl_test.c:

https://gerrit.osmocom.org/c/libosmocore/+/24639/1/tests/ctrl/ctrl_test.c@120 
PS1, Line 120: 
> this part seems unrelated to the commit log message. […]
It's not unrelated, I explain why is it related in the commit description.
the buffer is also checked with strcmp later, so I cannot do what you suggest.
"also:..." I don't get what do you mean here.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24639
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0b8f370f7b08736207f9efed13a0663b5e482824
Gerrit-Change-Number: 24639
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 15:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/02c26191/attachment.htm>


More information about the gerrit-log mailing list