Change in libosmocore[master]: ctrl: Pre-calculate required size before allocating msgb

keith gerrit-no-reply at lists.osmocom.org
Thu Jun 10 18:29:45 UTC 2021


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24639 )

Change subject: ctrl: Pre-calculate required size before allocating msgb
......................................................................


Patch Set 1: Code-Review+1

I don't mean to ignore neels' concerns.. 
All I can say is it WoЯks 4 m3.

I Note that osmo_ctrl.py from osmo-python-tests truncates output.
Maybe there might be other fallout to consider before merging this?


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24639
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0b8f370f7b08736207f9efed13a0663b5e482824
Gerrit-Change-Number: 24639
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Jun 2021 18:29:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210610/385dd64d/attachment.htm>


More information about the gerrit-log mailing list