Change in osmo-pcu[master]: Get rid of lots of code only used by tests

pespin gerrit-no-reply at lists.osmocom.org
Thu Jul 29 11:58:32 UTC 2021


Hello Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-pcu/+/25093

to look at the new patch set (#2).

Change subject: Get rid of lots of code only used by tests
......................................................................

Get rid of lots of code only used by tests

There are 2 methods "rcvd_dl_ack()" in osmo-pcu code. One is used by
osmo-pcu itself, and the other is only used in tests.
Changing the tests to use the same method as osmo-pcu allows removing
the second one, and with it, a lot of code and complexity out of
osmo-pcu.

Change-Id: I14d9312cb61534dc97fca83141b9c0cd933c9206
---
M src/decoding.cpp
M src/decoding.h
M src/encoding.cpp
M src/encoding.h
M src/tbf_dl.cpp
M src/tbf_dl.h
M tests/tbf/TbfTest.cpp
M tests/tbf/TbfTest.err
M tests/types/TypesTest.cpp
9 files changed, 129 insertions(+), 127 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/93/25093/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I14d9312cb61534dc97fca83141b9c0cd933c9206
Gerrit-Change-Number: 25093
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/438ebb17/attachment.htm>


More information about the gerrit-log mailing list