This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25093 ) Change subject: Get rid of lots of code only used by tests ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/25093/1/tests/tbf/TbfTest.err File tests/tbf/TbfTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/25093/1/tests/tbf/TbfTest.err@503 PS1, Line 503: 0 > why is it not BSN=85 anymore? same below Because last one was wrong (and nobody cared because it's not used in osmo-pcu). This line relates to first RCV_ACK in test_tbf_delayed_release(). In request_dl_rlc_block(), TBF starts sending with BSN 0. The previous update_window() method only used in the test was assuming first_bsn was always SSN-64, which of course didn't make sense here since we are using SSN of 1, 2, etc. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25093 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I14d9312cb61534dc97fca83141b9c0cd933c9206 Gerrit-Change-Number: 25093 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Thu, 29 Jul 2021 12:27:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/7c9e9a24/attachment.htm>