Change in osmo-pcu[master]: Get rid of lots of code only used by tests

osmith gerrit-no-reply at lists.osmocom.org
Thu Jul 29 08:27:41 UTC 2021


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25093 )

Change subject: Get rid of lots of code only used by tests
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/25093/1/tests/tbf/TbfTest.cpp 
File tests/tbf/TbfTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/25093/1/tests/tbf/TbfTest.cpp@263 
PS1, Line 263: #define RCV_ACK(fin, tbf, rbb) do { \
this macro is long and hard to read. can you convert it to a function?


https://gerrit.osmocom.org/c/osmo-pcu/+/25093/1/tests/tbf/TbfTest.err 
File tests/tbf/TbfTest.err:

https://gerrit.osmocom.org/c/osmo-pcu/+/25093/1/tests/tbf/TbfTest.err@503 
PS1, Line 503: 0
why is it not BSN=85 anymore? same below



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I14d9312cb61534dc97fca83141b9c0cd933c9206
Gerrit-Change-Number: 25093
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jul 2021 08:27:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210729/3cb7e03d/attachment.htm>


More information about the gerrit-log mailing list