Change in osmo-bts[master]: early IMM ASS: add configurable delay for RR IMM ASS

neels gerrit-no-reply at lists.osmocom.org
Wed Aug 18 15:16:38 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 )

Change subject: early IMM ASS: add configurable delay for RR IMM ASS
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c 
File src/common/lchan.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@34 
PS4, Line 34: 		/* The IA message has disappeared since the timer was started. */
> I guess this can happen from time to time. […]
If this situation arises, it must be from some channel release or failure, so there should be logging about what has happened to the lchan.


https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@45 
PS4, Line 45: 	/* Put RR IA msg into the AGCH queue of the BTS. */
comment dup


https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@78 
PS4, Line 78: 					    osmo_tdef_get(abis_T_defs, -15, OSMO_TDEF_US, -1));
> The -15 looks a bit strange on the first look, but I found it in abis_T_defs[], We do not use define […]
incidentally we most often now use FSM state names and state -> T relations in struct osmo_tdef_state_timeout tables. There's no FSM here, so just using the plain X15 number, i.e. -15.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e63b98944dc840cde212fc732e20277cdc5585
Gerrit-Change-Number: 25201
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Hoernchen <ewild at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 15:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210818/d387c4b6/attachment.htm>


More information about the gerrit-log mailing list