Change in osmo-bts[master]: early IMM ASS: add configurable delay for RR IMM ASS

dexter gerrit-no-reply at lists.osmocom.org
Thu Aug 19 07:00:32 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 )

Change subject: early IMM ASS: add configurable delay for RR IMM ASS
......................................................................


Patch Set 4:

(2 comments)

Thanks for your explaination.

https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c 
File src/common/lchan.c:

https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@34 
PS4, Line 34: 		/* The IA message has disappeared since the timer was started. */
> If this situation arises, it must be from some channel release or failure, so there should be loggin […]
Done


https://gerrit.osmocom.org/c/osmo-bts/+/25201/4/src/common/lchan.c@78 
PS4, Line 78: 					    osmo_tdef_get(abis_T_defs, -15, OSMO_TDEF_US, -1));
> incidentally we most often now use FSM state names and state -> T relations in struct osmo_tdef_stat […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e63b98944dc840cde212fc732e20277cdc5585
Gerrit-Change-Number: 25201
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Hoernchen <ewild at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 19 Aug 2021 07:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210819/6da09110/attachment.htm>


More information about the gerrit-log mailing list