Change in osmo-bts[master]: early IMM ASS: add configurable delay for RR IMM ASS
gerrit-no-reply at lists.osmocom.org
Wed Aug 18 15:06:36 UTC 2021
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25201 )
Change subject: early IMM ASS: add configurable delay for RR IMM ASS
Patch Set 4: Code-Review+1
I did not test this but it looks meaningful to me. I guess you made sure that this still passes the TTCN3 tests.
PS4, Line 34: /* The IA message has disappeared since the timer was started. */
I guess this can happen from time to time. If this is an odd situation, maybe a debug log message might be a good idea?
PS4, Line 78: osmo_tdef_get(abis_T_defs, -15, OSMO_TDEF_US, -1));
The -15 looks a bit strange on the first look, but I found it in abis_T_defs, We do not use define constants for that in this case i guess.
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25201
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-CC: Hoernchen <ewild at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 15:06:36 +0000
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the gerrit-log