Change in osmo-bsc[master]: Lb: add missing X12 timer configurability

neels gerrit-no-reply at lists.osmocom.org
Tue Apr 27 23:38:17 UTC 2021


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23914 )

Change subject: Lb: add missing X12 timer configurability
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review-1
> 
> Probably better to change to osmo_tdef_fsm_inst_state_chg -1:
> 
> #define lcs_ta_req_fsm_state_chg(FI, STATE) \
> 	osmo_tdef_fsm_inst_state_chg(FI, STATE, \
> 				     lcs_ta_req_fsm_timeouts, \
> 				     (bsc_gsmnet)->T_defs, \
> 				     5)   <---- HERE -1
> 
> This is less confusing since that value should always come from the T_defs now.

erm, that default timeout is an unsigned long.
It's only the osmo_tdef_fsm_inst_state_chg() macro api doc talking about -1, but there is no code that would abort the program. Any code that passes -1 would probably instead cause a timeout of 18446744073709551615 seconds. we should fix that comment: https://gerrit.osmocom.org/c/libosmocore/+/23925


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I19540f64de4937b39963bb66bebb1b5d433c2be2
Gerrit-Change-Number: 23914
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Apr 2021 23:38:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/417d93ab/attachment.htm>


More information about the gerrit-log mailing list