Change in osmo-bsc[master]: Lb: add missing X12 timer configurability

pespin gerrit-no-reply at lists.osmocom.org
Tue Apr 27 15:43:22 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23914 )

Change subject: Lb: add missing X12 timer configurability
......................................................................


Patch Set 1: Code-Review-1

Probably better to change to osmo_tdef_fsm_inst_state_chg -1:

#define lcs_ta_req_fsm_state_chg(FI, STATE) \
	osmo_tdef_fsm_inst_state_chg(FI, STATE, \
				     lcs_ta_req_fsm_timeouts, \
				     (bsc_gsmnet)->T_defs, \
				     5)   <---- HERE -1

This is less confusing since that value should always come from the T_defs now.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23914
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I19540f64de4937b39963bb66bebb1b5d433c2be2
Gerrit-Change-Number: 23914
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 27 Apr 2021 15:43:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210427/038f5059/attachment.htm>


More information about the gerrit-log mailing list