<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably better to change to osmo_tdef_fsm_inst_state_chg -1:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">#define lcs_ta_req_fsm_state_chg(FI, STATE) \<br>    osmo_tdef_fsm_inst_state_chg(FI, STATE, \<br>                                  lcs_ta_req_fsm_timeouts, \<br>                                    (bsc_gsmnet)->T_defs, \<br>                                    5)   <---- HERE -1</pre><p style="white-space: pre-wrap; word-wrap: break-word;">This is less confusing since that value should always come from the T_defs now.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">erm, that default timeout is an unsigned long.<br>It's only the osmo_tdef_fsm_inst_state_chg() macro api doc talking about -1, but there is no code that would abort the program. Any code that passes -1 would probably instead cause a timeout of 18446744073709551615 seconds. we should fix that comment: https://gerrit.osmocom.org/c/libosmocore/+/23925</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23914">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/23914">change 23914</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/23914"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I19540f64de4937b39963bb66bebb1b5d433c2be2 </div>
<div style="display:none"> Gerrit-Change-Number: 23914 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 27 Apr 2021 23:38:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>