Change in osmo-bts[master]: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command

dexter gerrit-no-reply at lists.osmocom.org
Fri Apr 16 10:10:06 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23774 )

Change subject: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

technically this should be fine. However, when I did the tagging of VTY commands I git the impression that l1if_provision_transceiver_trx() would negotiate the new rx-gain value. Apparantly this is not the case or does not work (I see l1if_provision_transceiver_trx() is not called anymore by the VTY).

https://gerrit.osmocom.org/c/osmo-bts/+/23774/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/23774/1//COMMIT_MSG@9 
PS1, Line 9: * Calling l1if_provision_transceiver_trx() yelds nothing.
typo "yelds" should be "yield" ?


https://gerrit.osmocom.org/c/osmo-bts/+/23774/1//COMMIT_MSG@11 
PS1, Line 11: 
I do not understand this fully. Always thought l1if_provision_transceiver_trx() would negotiate the new rx-gain value when it is called. I think a bit more info would be helpful.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23774
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e
Gerrit-Change-Number: 23774
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Apr 2021 10:10:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/10dd186f/attachment.htm>


More information about the gerrit-log mailing list