This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/23774 ) Change subject: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/23774/1/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/23774/1/src/osmo-bts-trx/trx_vty.c@357 PS1, Line 357: l1h->config.rxgain_sent = false; Ideally we should add a new FSM events to "enum trx_provision_fsm_events" in order to be able to configure this at any time: Here, one would dispatch event TRX_PROV_EV_CFG_RXGAIN with param=atoi(argv[0]), then the trx_provision_fsm would take care to internally store it and send TRXC message if requried at that point. TRX_PROV_EV_RXGAIN_CNF would be received once we got confirmation from TRXC. This would help in cleaning up this code, and also allow to set it at any time, no need to restart (assuming osmo-trx is also fine handling related TRXC commands at any time). Same goes for patch before this one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23774 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e Gerrit-Change-Number: 23774 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 16 Apr 2021 13:01:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/3d247ecf/attachment.htm>