Change in osmo-bts[master]: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command

fixeria gerrit-no-reply at lists.osmocom.org
Fri Apr 16 05:55:04 UTC 2021


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/23774 )


Change subject: osmo-bts-trx: correct definition of 'osmotrx rx-gain' command
......................................................................

osmo-bts-trx: correct definition of 'osmotrx rx-gain' command

* Calling l1if_provision_transceiver_trx() yelds nothing.
* It does not apply immediately, full restart required.

Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 6 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/74/23774/1

diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 9a205d5..86de602 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -342,12 +342,12 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN_ATTR(cfg_phyinst_rxgain, cfg_phyinst_rxgain_cmd,
-	   "osmotrx rx-gain <0-50>",
-	   OSMOTRX_STR
-	   "Set the receiver gain in dB\n"
-	   "Gain in dB\n",
-	   CMD_ATTR_IMMEDIATE)
+DEFUN_USRATTR(cfg_phyinst_rxgain, cfg_phyinst_rxgain_cmd,
+	      X(BTS_VTY_TRX_POWERCYCLE),
+	      "osmotrx rx-gain <0-50>",
+	      OSMOTRX_STR
+	      "Set the receiver gain in dB\n"
+	      "Gain in dB\n")
 {
 	struct phy_instance *pinst = vty->index;
 	struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
@@ -355,7 +355,6 @@
 	l1h->config.rxgain = atoi(argv[0]);
 	l1h->config.rxgain_valid = 1;
 	l1h->config.rxgain_sent = false;
-	l1if_provision_transceiver_trx(l1h);
 
 	return CMD_SUCCESS;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/23774
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I93c9e19d0543f19528cec842b8be332b4d93214e
Gerrit-Change-Number: 23774
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210416/f1bbe81c/attachment.htm>


More information about the gerrit-log mailing list