Change in simtrace2[master]: cardem: ensure VCC_PHONE is floating

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 14 10:59:53 UTC 2021


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/23621 )

Change subject: cardem: ensure VCC_PHONE is floating
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

I do not have a good overview in the simtrace project at the moment, however what you describe in the commit message makes (electrically) sense to me.

https://gerrit.osmocom.org/c/simtrace2/+/23621/2/firmware/libcommon/source/mode_cardemu.c 
File firmware/libcommon/source/mode_cardemu.c:

https://gerrit.osmocom.org/c/simtrace2/+/23621/2/firmware/libcommon/source/mode_cardemu.c@546 
PS2, Line 546: #ifdef PINS_PWR_CARDEMU
c++ comment style in a c-file?



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23621
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ib261073e3779ae7d98de18ce78b34ff37eafeaa2
Gerrit-Change-Number: 23621
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Apr 2021 10:59:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210414/4c9edbff/attachment.htm>


More information about the gerrit-log mailing list