This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orgHello tsaitgaist, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/simtrace2/+/23622 to review the following change. Change subject: cardem: fix TPDU state check ...................................................................... cardem: fix TPDU state check this change allows to initialize the TPDU state while in ISO_S_WAIT_TPDU, before actually entering ISO_S_TPDU Change-Id: I505d3add32a43de31499b800bc53442f99f65931 --- M firmware/libcommon/source/card_emu.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/22/23622/1 diff --git a/firmware/libcommon/source/card_emu.c b/firmware/libcommon/source/card_emu.c index fb532d5..259d48e 100644 --- a/firmware/libcommon/source/card_emu.c +++ b/firmware/libcommon/source/card_emu.c @@ -826,7 +826,7 @@ { if (ch->tpdu.state == new_ts) return; - if (ISO_S_IN_TPDU != ch->state) { + if (ISO_S_IN_TPDU != ch->state && ISO_S_WAIT_TPDU != ch->state) { TRACE_ERROR("%u: setting TPDU state in %s state\r\n", ch->num, get_value_string(iso7816_3_card_state_names, ch->state)); } -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/23622 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I505d3add32a43de31499b800bc53442f99f65931 Gerrit-Change-Number: 23622 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210404/1212d7a8/attachment.htm>