<p style="white-space: pre-wrap; word-wrap: break-word;">I do not have a good overview in the simtrace project at the moment, however what you describe in the commit message makes (electrically) sense to me.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23621">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/simtrace2/+/23621/2/firmware/libcommon/source/mode_cardemu.c">File firmware/libcommon/source/mode_cardemu.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/simtrace2/+/23621/2/firmware/libcommon/source/mode_cardemu.c@546">Patch Set #2, Line 546:</a> <code style="font-family:monospace,monospace">#ifdef PINS_PWR_CARDEMU</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">c++ comment style in a c-file?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/simtrace2/+/23621">change 23621</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/simtrace2/+/23621"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: simtrace2 </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib261073e3779ae7d98de18ce78b34ff37eafeaa2 </div>
<div style="display:none"> Gerrit-Change-Number: 23621 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: tsaitgaist <kredon@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 14 Apr 2021 10:59:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>